docs: fix incorrect HSTS max-age value in FAQ#79
Open
mahmoodhamdi wants to merge 1 commit intohelmetjs:mainfrom
Open
docs: fix incorrect HSTS max-age value in FAQ#79mahmoodhamdi wants to merge 1 commit intohelmetjs:mainfrom
mahmoodhamdi wants to merge 1 commit intohelmetjs:mainfrom
Conversation
The "You might not need Helmet" page had max-age=15552000 (180 days) but Helmet's actual default is max-age=31536000 (365 days), as shown in the HSTS source code and the main reference page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "You might not need Helmet" FAQ page had
max-age=15552000(180 days) for theStrict-Transport-Securityheader, but Helmet's actual default ismax-age=31536000(365 days).This matches the value shown on the main reference page and in the HSTS source code (
365 * 24 * 60 * 60 = 31536000).