Skip to content

feat: align frame range to (likely) page size when initializing physical memory #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: align frame range to (likely) page size when initializing physical memory #1827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/mm/physicalmem.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use memory_addresses::{PhysAddr, VirtAddr};

#[cfg(target_arch = "x86_64")]
use crate::arch::mm::paging::PageTableEntryFlagsExt;
use crate::arch::mm::paging::{self, HugePageSize, PageSize, PageTableEntryFlags};
use crate::arch::mm::paging::{self, HugePageSize, LargePageSize, PageSize, PageTableEntryFlags};
use crate::env;
use crate::mm::device_alloc::DeviceAlloc;

Expand Down Expand Up @@ -78,9 +78,21 @@ fn detect_from_fdt() -> Result<(), ()> {
let biggest_region = all_regions.max_by_key(|m| m.size.unwrap()).unwrap();
found_ram = true;

let size = {
let base = biggest_region.size.unwrap();
if base.is_multiple_of(LargePageSize::SIZE as usize) {
base
} else {
base.next_multiple_of(LargePageSize::SIZE as usize) - LargePageSize::SIZE as usize
}
};

let range = PageRange::from_start_len(
biggest_region.starting_address.addr(),
biggest_region.size.unwrap(),
biggest_region
.starting_address
.addr()
.next_multiple_of(LargePageSize::SIZE as usize),
size,
)
.unwrap();

Expand Down
Loading