-
Notifications
You must be signed in to change notification settings - Fork 13
Upgrade @modelcontextprotocol/sdk package #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
077ba08
to
2df3bc5
Compare
Also adds eslint support for .spechelper.ts files
fd286c3
to
37ad9ed
Compare
justinwilaby
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the typescript errors we encountered when upgrading @modelcontextprotocol/sdk to version 1.16.0.
Root Cause: The MCP SDK upgrade introduced a breaking change in the server.tool() method signature, adding an annotations parameter between the schema and callback parameters.
Due to this change, all of the
server.tool.callsFake...
invocations with fixed params were resulting in typescript errors.This is a follow up to #75
My approach was to add a spec helper for setting up mocks for the MCP tool tests with the resolved typescript errors, and then implement it in all of the affected files.