Skip to content

Conversation

jwagantall
Copy link
Contributor

For more information: https://github.com/cncf/gitvote

@jwagantall jwagantall requested review from a team as code owners July 22, 2025 17:58
@jwagantall jwagantall requested a review from jasperpotts July 22, 2025 17:58
@Nana-EC
Copy link
Contributor

Nana-EC commented Jul 23, 2025

Thanks @jwagantall.
I can see this being utilized well on Issues.
In the PR case when a repo has a min required signs offs where do you think the voting system would be valuable in comparison to just having the PR being approved?

@Nana-EC Nana-EC added Improvement Code changes driven by non business requirements Block Node Issues/PR related to the Block Node. labels Jul 23, 2025
@Nana-EC Nana-EC added this to the 0.16.0 milestone Jul 23, 2025
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwagantall
Copy link
Contributor Author

Thanks @jwagantall. I can see this being utilized well on Issues. In the PR case when a repo has a min required signs offs where do you think the voting system would be valuable in comparison to just having the PR being approved?

IMO, I think for PRs is either or. While approving the code itself is a way of voting too, we might not need to use GitVote to run an approval of the PR.

I think this feature comes in handy more on Issues for sure.

It depends on the community which one they want to use but for now this is added as an option to the core repos.

@Nana-EC Nana-EC modified the milestone: 0.16.0 Jul 30, 2025
@Nana-EC Nana-EC force-pushed the jwagantall-patch-1 branch from 64af161 to 5ff3eb4 Compare August 9, 2025 03:45
@AlfredoG87 AlfredoG87 modified the milestones: 0.16.0, 0.17.0 Aug 13, 2025
@AlfredoG87 AlfredoG87 modified the milestones: 0.17.0, 0.18.0 Aug 25, 2025
@jsync-swirlds jsync-swirlds merged commit d0ec867 into main Sep 3, 2025
13 of 15 checks passed
@jsync-swirlds jsync-swirlds deleted the jwagantall-patch-1 branch September 3, 2025 22:25
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff              @@
##               main    #1410      +/-   ##
============================================
- Coverage     80.72%   80.47%   -0.26%     
+ Complexity     1115     1108       -7     
============================================
  Files           123      123              
  Lines          5147     5147              
  Branches        533      533              
============================================
- Hits           4155     4142      -13     
- Misses          754      768      +14     
+ Partials        238      237       -1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants