feat: add TokenPendingAirdrop Transaction #213
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xivanov
reviewed
Jul 24, 2025
src/hiero_sdk_python/tokens/token_airdrop_pending_transaction.py
Outdated
Show resolved
Hide resolved
|
got a working detailed example of token claim aidrop but that needs a lot of tidying up lol, including checking consistency and names, after that will complete the unit and integration tests |
|
rebased and completed unit tests, need to add integration test tomorrow |
exploreriii
force-pushed
the
feat-addPendingAirdropId
branch
2 times, most recently
from
e11afcb to
d625a5e
Compare
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: Piyush Kumar <[email protected]>
Signed-off-by: Piyush Kumar <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
…ations next Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]> chore: add docstrings, linting, mypy to claim airdrop Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
Signed-off-by: exploreriii <[email protected]>
exploreriii
force-pushed
the
feat-addPendingAirdropId
branch
from
bc9431e to
5019190
Compare
|
sorry, had some issues rebasing and signing. |
|
still outstanding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft work in progress, in collaboration with @piyush588. Publishing a little haphazardly because I cannot spend more time on this right now, likely until the weekend, and would like to pass chunks on.
Building from @manishdait work on Pending Airdrop ID
So far:
x PendingAirdropID extended
Still need to triple check requirements are met
x Some PendingAirDropID test extended
Not complete
x Good outline for TokenPendingAirdropTransaction with several useful methods
Need to decide on consistency with other transactions, I can see some use 'set' others 'add' and others build_transaction_body others proto.
Need to triple check logic and robustness tests
Might have to extend class attributes depending on desired test functionality
x No unit test for TokenPendingAirdropTransaction
x No integration test for TokenPendingAirdropTransaction