ci: add GitHub Action for Mypy type checking (continue-on-error) #280
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mounil <[email protected]> Signed-off-by: Mounil <[email protected]>
…file linking. Signed-off-by: Mounil <[email protected]>
Mounil2005
force-pushed
the
issue-mypy-action
branch
from
e7beda9 to
e460238
Compare
This comment was marked as outdated.
This comment was marked as outdated.
exploreriii
reviewed
Aug 18, 2025
This comment was marked as outdated.
This comment was marked as outdated.
exploreriii
reviewed
Aug 19, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
this could be merged with the new CI later, but lets keep it seperate for the scope of this PR: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Mounil2005
force-pushed
the
issue-mypy-action
branch
from
0d373e2 to
632b368
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Mounil2005
force-pushed
the
issue-mypy-action
branch
from
632b368 to
732e666
Compare
Signed-off-by: Mounil <[email protected]>
Signed-off-by: Mounil <[email protected]>
Mounil2005
force-pushed
the
issue-mypy-action
branch
from
732e666 to
7e35fb3
Compare
Signed-off-by: Mounil <[email protected]>
Mounil2005
force-pushed
the
issue-mypy-action
branch
from
7e35fb3 to
8ffcea8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Mounil <[email protected]>
exploreriii
reviewed
Aug 22, 2025
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt || true |
There was a problem hiding this comment.
do we have a requirements file?
|
|
||
| - name: Run mypy | ||
| run: | | ||
| mypy src/hiero_sdk_python |
There was a problem hiding this comment.
will you want to test the examples and the test files?
|
Closing this PR. I’ll open a clean PR from a new fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add GitHub Action workflow to run Mypy type checking using the existing mypy.ini configuration.
Add .github/workflows/mypy.yml
Run Mypy on push and pull requests
Set continue-on-error: true so type errors are reported but do not block merges
Related issue(s):
Fixes #273
Notes for reviewer:
The workflow reads the current mypy.ini settings.
Type check results will appear in GitHub Actions for developer and reviewer reference.
Checklist
[✅] Documented (Code comments, README, etc.)
[✅] Tested (workflow triggers and Mypy run successfully)