Skip to content

Add toString to IPv4 and IPv6 addresses #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add toString to IPv4 and IPv6 addresses #2

wants to merge 1 commit into from

Conversation

Ozame
Copy link

@Ozame Ozame commented Jul 7, 2025

  • By default the toString for IPv6 uses the compressed representation

See #1 for discussion

@Ozame
Add toString to IPv4 and IPv6 addresses
ebd78ef 
- By default the toString for IPv6 uses the
compressed representation
@hirsivaja
Copy link
Owner

Thank you for your PR!

I agree that adding a toString-method to the addresses is a good change.

But I would rather use
this.toInetAddress().toString();
than implement the code from scratch.

Can you change the code to that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ozame @hirsivaja