Skip to content

Conversation

@maximlt
Copy link
Member

@maximlt maximlt commented Nov 18, 2025

Fixes #1100

When a Parameter has already been instantiated (it is in the _param__private.params dict), we don't need to touch the class parameter.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (5517f87) to head (57b2622).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files           9        9           
  Lines        4715     4716    +1     
=======================================
+ Hits         4207     4208    +1     
  Misses        508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors with new edit_constant implementation

2 participants