Repository navigation
Vulkan: Don't recreate the swapchain over a pre-transform we chose ourselves - #22453
Merged
Merged
Conversation
…rselves InitSwapchain deliberately refuses the 270 degree pre-transform. The driver then reports VK_SUBOPTIMAL_KHR on every present, which we counted towards recreating the swapchain - and the new one got the same treatment, so in reverse landscape we rebuilt it every single frame. Remember that the mismatch is ours and stop treating SUBOPTIMAL as a reason to recreate when it is. Any other cause still counts. Split out of the Android rotation work, where it was found: it's a platform-independent Vulkan fix and stands on its own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01152igCdjTNhT29qvphPyPC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out by Claude from a larger branch of Android fixes.
InitSwapchain deliberately refuses the 270 degree pre-transform. The driver then reports VK_SUBOPTIMAL_KHR on every present, which we counted towards recreating the swapchain - and the new one got the same treatment, so in reverse landscape we rebuilt it every single frame.
Remember that the mismatch is ours and stop treating SUBOPTIMAL as a reason to recreate when it is. Any other cause still counts.