Skip to content

add createPartitions test #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add createPartitions test #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 104 additions & 5 deletions app/src/test/java/io/hstream/kafka/testing/TopicTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
package io.hstream.kafka.testing;

import static org.assertj.core.api.Assertions.assertThatNoException;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.*;

import java.util.Collections;
import java.util.List;
import java.util.Properties;
import java.util.concurrent.ExecutionException;
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.admin.AdminClientConfig;
import org.apache.kafka.clients.admin.NewTopic;
import org.apache.kafka.clients.admin.*;
import org.apache.kafka.common.errors.InvalidPartitionsException;
import org.apache.kafka.common.errors.InvalidRequestException;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -68,4 +67,104 @@ void testCreateTopic() {
.get());
}
}

@Test
void testCreatePartition() throws ExecutionException, InterruptedException {
NewTopic topic1 = new NewTopic("test_create_partition_topic1", 1, (short) 1);
NewTopic topic2 = new NewTopic("test_create_partition_topic2", 3, (short) 3);
try {
assertThatNoException()
.as("create topics should success")
.isThrownBy(() -> client.createTopics(List.of(topic1, topic2)).all().get());

assertThatThrownBy(
() ->
client
.createPartitions(
Collections.singletonMap(
topic1.name(),
NewPartitions.increaseTo(2, Collections.singletonList(List.of(0)))))
.all()
.get())
.as("create partitions with assignment should fail")
.cause()
.isInstanceOf(InvalidRequestException.class);
assertThatThrownBy(
() ->
client
.createPartitions(
Collections.singletonMap(topic1.name(), NewPartitions.increaseTo(1)))
.all()
.get())
.as("new partition count should be greater than old partition count")
.cause()
.isInstanceOf(InvalidPartitionsException.class);
assertThatThrownBy(
() ->
client
.createPartitions(
Collections.singletonMap(topic2.name(), NewPartitions.increaseTo(2)))
.all()
.get())
.as("new partition count should be greater than old partition count")
.cause()
.isInstanceOf(InvalidPartitionsException.class);
assertThatNoException()
.as("create partitions should success")
.isThrownBy(
() ->
client
.createPartitions(
Collections.singletonMap(topic2.name(), NewPartitions.increaseTo(6)))
.all()
.get());
assertThatNoException()
.as("create partitions with validateOnly should success")
.isThrownBy(
() ->
client
.createPartitions(
Collections.singletonMap(topic1.name(), NewPartitions.increaseTo(6)),
new CreatePartitionsOptions().validateOnly(true))
.all()
.get());

assertThat(
client
.describeTopics(List.of(topic1.name()))
.allTopicNames()
.get()
.get(topic1.name())
.partitions()
.size())
.as("partition count for topic1 should be 1")
.isEqualTo(1);

var partitions =
client
.describeTopics(List.of(topic2.name()))
.allTopicNames()
.get()
.get(topic2.name())
.partitions();
assertThat(partitions.size()).as("partition count should be 6").isEqualTo(6);
// check failed because https://emqx.atlassian.net/browse/HS-4482
// for (var partition : partitions) {
// logger.info("partition: {}, replicas: {}", partition.partition(),
// partition.replicas().size());
// assertThat(partition.replicas().size()).as("replica count should be
// 3").isEqualTo(3);
// }

} finally {
assertThatNoException()
.isThrownBy(
() ->
client
.deleteTopics(
List.of("test_create_partition_topic1", "test_create_partition_topic2"))
.all()
.get());
}
}
}