Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for FlashPack
FlashPack could be used as weight format only (see:
load_flashpack_checkpoint) - keeping only weight format code would be a cleaner integration, the model loading is indeed faster[1] however part of the performance difference seems to be just due to the complexity of existingfrom_pretrainedcode, for example I noticed that_caching_allocator_warmupslows things down, alsoempty_device_cacheis called in_load_pretrained_modelwhereas FlashPack's code doesn't thus the empty cache time is excluded from FlashPack's benchmark results.is_flashpack_availablecheck logging, etc)silent,num_streams,use_distributed_loadingetc.)Benchmark
Changes from FlashPack's version:
transformersrelated code[1] For
bfloat16- withfloat16existing code appears to be fasterWho can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.