Skip to content

Fixes #12673. record_stream in group offloading is not working properly #12721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes #12673. record_stream in group offloading is not working properly #12721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef1ed6
Fixes #12673. `record_stream` is not working properly
KimbingNg Nov 26, 2025
60444c5
device.type != 'cpu'
KimbingNg Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/diffusers/hooks/group_offloading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ def _pinned_memory_tensors(self):

def _transfer_tensor_to_device(self, tensor, source_tensor):
tensor.data = source_tensor.to(self.onload_device, non_blocking=self.non_blocking)
if self.record_stream:
tensor.data.record_stream(self._torch_accelerator_module.current_stream())

def _process_tensors_from_modules(self, pinned_memory=None):
for group_module in self.modules:
Expand Down Expand Up @@ -238,12 +236,20 @@ def _offload_to_memory(self):
if not self.record_stream:
self._torch_accelerator_module.current_stream().synchronize()

current_stream = self._torch_accelerator_module.current_stream()

for group_module in self.modules:
for param in group_module.parameters():
if self.record_stream and param.device.type != 'cpu':
param.data.record_stream(current_stream)
param.data = self.cpu_param_dict[param]
for param in self.parameters:
if self.record_stream and param.device.type != 'cpu':
param.data.record_stream(current_stream)
param.data = self.cpu_param_dict[param]
for buffer in self.buffers:
if self.record_stream and buffer.device.type != 'cpu':
buffer.data.record_stream(current_stream)
buffer.data = self.cpu_param_dict[buffer]
else:
for group_module in self.modules:
Expand Down
Loading