fix: handle ChatMessage objects in log_messages method #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketan0
force-pushed
the
fix/log-messages-chatmessage-objects
branch
from
ad1a68e to
18cc5f1
Compare
src/smolagents/memory.py
Outdated
| logger.log_messages(step.model_input_messages, level=LogLevel.ERROR) | ||
| # Convert ChatMessage objects to dicts for logging | ||
| messages_as_dicts = [ | ||
| msg.dict() if hasattr(msg, 'dict') else dict(msg) |
There was a problem hiding this comment.
Why this if/else?
There was a problem hiding this comment.
good point, not needed! just fixed to do .dict() directly
… sites - Modified memory.py to convert ChatMessage objects to dicts before calling log_messages - Kept AgentLogger.log_messages interface clean - only accepts list[dict] as documented - Fixes TypeError when calling agent.replay(detailed=True) - Conversion happens at the 2 call sites in ActionStep and PlanningStep replay - Maintains type safety and clear separation of concerns This cleaner approach: - Makes the log_messages interface predictable and type-safe - Explicitly converts ChatMessage objects where they're used - Avoids mixing domain objects with logging utilities - Follows 'be conservative in what you send' principle Resolves issue where replay(detailed=True) would crash with: TypeError: 'ChatMessage' object is not iterable
ketan0
force-pushed
the
fix/log-messages-chatmessage-objects
branch
from
18cc5f1 to
bbb5fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix agent.replay(detailed=True) crashing with TypeError
The AgentLogger.log_messages method expects list[dict] but receives ChatMessage objects when replay() is called with detailed=True, causing:
This PR fixes the issue by converting ChatMessage objects to dicts at the call sites in memory.py before passing them to log_messages, maintaining a clean interface.
Changes:
Now users can debug the full LLM input/output flow with
agent.replay(detailed=True)without crashes.