Skip to content

Conversation

Jwaminju
Copy link

@Jwaminju Jwaminju commented Sep 6, 2025

What does this PR do?

Translated the default_tools.md file of the documentation to Korean 😄
Thank you in advance for your review!

Part of huggingface/transformers#20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@jungnerd @ahnjj @yijun-lee
Could you review this PR? Really appreciate for your review!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR?
Documentation maintainers

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I noticed that you opened and closed several PRs (around 9–10) for essentially the same contribution. This creates unnecessary noise and makes project maintenance harder.

If you're unsure about how PRs work, I'd recommend asking for guidance: we're happy to help you get started and contribute more effectively.

@Jwaminju
Copy link
Author

Jwaminju commented Sep 15, 2025

Hi @albertvillanova,

Sorry for the noise caused by repeatedly opening and closing PRs.
I was testing i18n-agent, an automation tool for i18n projects for Korean documentation, and I apologize for not being more careful.

After discussing with my local colleagues, I decided to change my testing approach to use the PR preview feature, so I can review my PRs before pushing them to the main repository.
I’ll make sure to carefully follow the contributing guidelines moving forward. Thanks a lot for your kind feedback!

Best Regards,
Minju

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants