Fix TruncationDirection to deserialize from lowercase and capitalized
#755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `#[serde(alias = "...", ...)]` we wouldn't break anything user-wise, whilst allowing for both "left"/"Left" and "right"/"Right" to be provided as `truncation_direction` other than only the capitalized version of those
alvarobartt
changed the title
TruncationDirection by renaming to lowercaseTruncationDirection to deserialize from lowercase and capitalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
#[serde(alias = "...")]toTruncationDirectionon HTTP to make sure that the enum variants deserialize from lowercase too e.g.{..., "truncation_direction":"left", ...}as previously it was only deserializing from the enum variant counterpart e.g.,Left.This PR partially fixes #754, but there's still some more issues to tackle as per the
openapi.jsonspecification as reported in the issue.Warning
Rather than removing the "Left" and "Right" values enforcing those to be lowercased, to make sure this is introduced in the best way possible, from now on both variants (lowercase and capitalized) are supported for
truncation_directionbut only the lowercase will be recommended.Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
cc @Wauplin for visibility!