Skip to content

Multi modality fix #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025
Merged

Multi modality fix #3283

merged 3 commits into from
Aug 19, 2025

Conversation

sywangyi
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

sywangyi added 3 commits June 29, 2025 22:17
…oes not. so split the case.

Signed-off-by: Wang, Yi A <[email protected]>
Signed-off-by: Wang, Yi A <[email protected]>
Signed-off-by: Wang, Yi A <[email protected]>
@sywangyi
Copy link
Contributor Author

fix multi-modality issue in xpu.

@sywangyi
Copy link
Contributor Author

@Narsil please help review and merge,thanks

@sywangyi
Copy link
Contributor Author

sywangyi commented Jul 4, 2025

@regisss please help review and merge.

@regisss
Copy link
Collaborator

regisss commented Jul 8, 2025

I'll let TGI maintainers review this one, I don't know the TGI codebase well enough

Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but a second look would be great

@yao-matrix
Copy link

@regisss do you know who is the right guy for second look? Thx

@regisss regisss merged commit 5284b5c into huggingface:main Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants