Remove build files from repository #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
remove-build-files
branch
from
480a700 to
4e7165c
Compare
|
Originally the app had to be hosted in a web server (the support for the FileSystemAccess API was added just a year ago), so the bundled files were included for users that didn't have experience with node/npm. I agree with the benefits of removing them now, but I'd need to check with our friend @JesusGod-Pope666-Info if he's ready to install Node and try bundling it himself :) |
Ignore custom user configuration file
Borewit
force-pushed
the
remove-build-files
branch
from
4e7165c to
55026d6
Compare
|
Why not build the distribution in a pipeline (Git workflow)? That way you can also exclude files which do not belong in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the build artifacts from version control. These files are typically generated during the build process and are not necessary to track in Git.
Benefits:
The build artifacts can still be produced using
npm run build