Add option for explicit nested AND sub-queries

[peterbroadhurst]

I hit a scenario that I couldn't describe with our JSONQuery syntax.

See in this test, we have a top-level AND where one of the sub-queries is an OR. This couldn't be described before.

firefly-common/pkg/ffapi/restfilter_json_test.go

Lines 145 to 176 in 8f24fbf

	err := json.Unmarshal([]byte(`{
	"and": [
	{
	"or": [
	{
	"equal": [
	{
	"field": "tag",
	"value": "a"
	}
	]
	},
	{
	"equal": [
	{
	"field": "tag",
	"value": "b"
	}
	]
	}
	]
	},
	{
	"equal": [
	{
	"field": "cid",
	"value": "12345"
	}
	]
	}
	]
	}`), &qf)

[peterbroadhurst]

What happens in the swagger generator is this:

        or:
          items:
            $ref: '#/components/schemas/FilterJSON'
          type: array

Then depending on non-deterministic behavior, the FilterJSON schema gets a description from _ethertheandoror` definition.

That makes swagger generation non-deterministic.

IMHO this is a bug, and the swagger should look like this - but that would be a hard contribution to build+validate to the openapi3gen package:

        or:
          description: "the description of the reference to the object"
          items:
            $ref: '#/components/schemas/FilterJSON'
          type: array

[EnriqueL8]

Do we want to raise this as an issue to the openapi3gen pkg or/and this repo before we forget about this thinking?

[EnriqueL8]

Looks great @peterbroadhurst - left a few suggestions of typos and question on raising issue.

[EnriqueL8]

Suggested change

	// And creates an OR condition between multiple queries
	// And creates an AND condition between multiple queries

[EnriqueL8]

Suggested change

	// Or creates an AND condition between multiple queries
	// And creates an AND condition between multiple queries

[EnriqueL8]

Do we want to raise this as an issue to the openapi3gen pkg or/and this repo before we forget about this thinking?