Skip to content

return transaction receipt as part of the confirmation response #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

return transaction receipt as part of the confirmation response #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pkg/ffcapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,12 @@ type ConfirmationUpdateResult struct {
// in the in-memory partial chain
// WARNING: mutation to this list is not expected, invalid modifications will cause inefficiencies in the reconciliation process
// `rebuilt` will be true if an invalid confirmation list is detected by the reconciliation process
Confirmations []*MinimalBlockInfo `json:"confirmations,omitempty"`
Rebuilt bool `json:"rebuilt,omitempty"` // when true, it means the existing confirmations contained invalid blocks, the new confirmations are rebuilt from scratch
NewFork bool `json:"newFork,omitempty"` // when true, it means a new fork was detected based on the existing confirmations
Confirmed bool `json:"confirmed,omitempty"` // when true, it means the confirmation list is complete and the transaction is confirmed
TargetConfirmationCount uint64 `json:"targetConfirmationCount"` // the target number of confirmations for this reconcile request
Confirmations []*MinimalBlockInfo `json:"confirmations,omitempty"`
Receipt *TransactionReceiptResponse `json:"receipt,omitempty"` // receipt for the transaction
Rebuilt bool `json:"rebuilt,omitempty"` // when true, it means the existing confirmations contained invalid blocks, the new confirmations are rebuilt from scratch
NewFork bool `json:"newFork,omitempty"` // when true, it means a new fork was detected based on the existing confirmations
Confirmed bool `json:"confirmed,omitempty"` // when true, it means the confirmation list is complete and the transaction is confirmed
TargetConfirmationCount uint64 `json:"targetConfirmationCount"` // the target number of confirmations for this reconcile request
}
type MinimalBlockInfo struct { // duplicate of apitypes.Confirmation due to circular dependency
BlockNumber fftypes.FFuint64 `json:"blockNumber"`
Expand Down