Skip to content

fix: Subscribe API Meta and UserMeta fields wrong #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fovecifer
Copy link

Description

I am using Subscribe API to listening the key changes, I found the Meta and UserMeta in pb.KV were wrong

@fovecifer fovecifer requested a review from a team as a code owner July 18, 2025 01:39
@mangalaman93
Copy link
Member

Thank you for the PR. I do not think this is a bug. This is expected because the internal meta is not useful to the caller and hence, we write the UserMeta into meta before publishing.

@fovecifer
Copy link
Author

Thank you for the PR. I do not think this is a bug. This is expected because the internal meta is not useful to the caller and hence, we write the UserMeta into meta before publishing.

Why not write the UserMeta into UserMeta? as a caller of the Subscribe API, I was confused where to get my UserMeta

@mangalaman93
Copy link
Member

Yes, that maybe right but I would not like to break the API. Is it a big deal for your use case?

@fovecifer
Copy link
Author

Yes, that maybe right but I would not like to break the API. Is it a big deal for your use case?

Yes, I use this subscribe API to implement "replication" feature. I need the UserMeta and the "bitDiscardEarlierVersions" of Meta.
Currently, I use my fork of badger in my project, it is doing well.

@mangalaman93
Copy link
Member

Do you mind explaining why you are using a fork? Is this PR the reason for it? Thank you patiently answering my questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants