IBX-9060: Revamp notifications #1529

albozek · 2025-04-24T14:55:12Z

🎫 Issue	IBX-9060

Related PRs:

Description:

For QA:

Documentation:

Copilot

Pull Request Overview

This PR revamps the notifications functionality and introduces new sidebar interactions while updating related configuration and routing. Key changes include:

Introducing a new sidebar panel with improved event handling and backdrop management.
Revamping notifications modal and list functionality by adding support for actions such as marking notifications as read/unread, bulk operations, and deletion.
Updating routing, service configurations, and default settings to support the new notifications features.

Reviewed Changes

Copilot reviewed 27 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/bundle/Resources/public/js/scripts/sidebar/side.panel.js	New sidebar panel implementation with close triggers and backdrop control.
src/bundle/Resources/public/js/scripts/admin.notifications.modal.js	Updates to notifications modal including new actions and improved event management.
src/bundle/Resources/public/js/scripts/admin.notifications.list.js	Introduction of notifications list with bulk operations and status management.
src/bundle/Resources/public/js/scripts/admin.notifications.filters.js	New filters implementation for notifications.
src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js	Improvement in multilevel popup menu initialization with refactored event handling.
src/bundle/Resources/encore/ibexa.js.config.js	Updated configuration to include new notifications list entry.
src/bundle/Resources/config/services/controllers.yaml	Added new controller service definitions for notifications.
src/bundle/Resources/config/routing.yaml	Introduced new routes to support notifications actions.
src/bundle/Resources/config/ezplatform_default_settings.yaml	Increased pagination limit for notifications.

Files not reviewed (11)

src/bundle/Controller/AllNotificationsController.php: Language not supported
src/bundle/Controller/NotificationController.php: Language not supported
src/bundle/Form/Data/SearchQueryData.php: Language not supported
src/bundle/Form/Type/SearchType.php: Language not supported
src/bundle/Resources/public/scss/_header-user-menu.scss: Language not supported
src/bundle/Resources/public/scss/_list-filters.scss: Language not supported
src/bundle/Resources/public/scss/_notifications-modal.scss: Language not supported
src/bundle/Resources/public/scss/_notifications.scss: Language not supported
src/bundle/Resources/public/scss/_side-panel.scss: Language not supported
src/bundle/Resources/public/scss/ibexa.scss: Language not supported
src/bundle/Resources/translations/ibexa_admin_ui.en.xliff: Language not supported

Comments suppressed due to low confidence (1)

src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js:2

[nitpick] The function name 'initMutlilevelPopupMenus' appears to contain a typographical error; consider renaming it to 'initMultilevelPopupMenus' for clarity.

const initMutlilevelPopupMenus = (container) => {

src/bundle/Resources/public/js/scripts/admin.notifications.list.js

src/bundle/Resources/public/js/scripts/admin.notifications.filters.js

src/bundle/Resources/public/js/scripts/admin.notifications.list.js

src/bundle/Resources/public/scss/_notifications-modal.scss

src/bundle/Resources/views/themes/admin/account/notifications/side_panel.html.twig

src/bundle/Resources/views/themes/admin/ui/component/side_panel/side_panel.html.twig

…AsUnreadAction

…controller logic

src/bundle/Controller/NotificationController.php

src/lib/Form/Type/Notification/NotificationTypeChoiceType.php

src/lib/Form/Type/Notification/NotificationStatusChoiceType.php

src/bundle/Resources/config/routing.yaml

…ency, improved error handling, and updated forms and translations.

src/bundle/Controller/NotificationController.php

… deletion flow.

src/bundle/Controller/NotificationController.php

KamilSznajdrowicz

When checkout the PR to my environment, I encounter errors when editing and saving e.g sections, articles, etc., which reflect the errors on CI: https://github.com/ibexa/admin-ui/actions/runs/16902334497/job/47883992235?pr=1529

Nagranie.z.ekranu.2025-08-14.o.11.45.54.mov

Wrong view displayed when there are no notifications.

"Mark as Read" should be disabled (grayed out) when there are no notifications, according to the design.
"Mark as Read" should dynamically change to "Mark as Unread" after clicking, but this currently happens only after refreshing the page.

Nagranie.z.ekranu.2025-08-14.o.11.49.26.mov

# Conflicts: # phpstan-baseline.neon # src/lib/Form/Factory/FormFactory.php

src/bundle/Resources/public/js/scripts/admin.notifications.modal.js

GrabowskiM · 2025-08-19T11:31:34Z

src/bundle/Resources/public/js/scripts/sidebar/side.panel.js

@@ -20,6 +20,9 @@
                sidePanel.classList.add(CLASS_HIDDEN);
                doc.body.removeEventListener('click', handleClickOutside, false);
                removeBackdrop();
+                if (global.location.href.includes('notifications/render/all')) {


new line before

And I'm not sure if we can use hardcoded string url for this check, needs someone else expertise

KamilSznajdrowicz

There are still a lot of errors on CI.
https://github.com/ibexa/admin-ui/actions/runs/17070310234
Please make sure CI is green. The issues that can be identified include, among others: Translation errors (https://github.com/ibexa/admin-ui/actions/runs/17070310234/job/48397245853#step:18:44 , https://github.com/ibexa/admin-ui/actions/runs/17070310234/job/48397246236#step:18:531) :

Dropdowns not opening (https://github.com/ibexa/admin-ui/actions/runs/17070310234/job/48397246183#step:18:442) :

Nagranie.z.ekranu.2025-08-20.o.11.16.23.mov

Nagranie.z.ekranu.2025-08-20.o.21.01.04.mov

I can't navigate to other sections in the user profile. (https://github.com/ibexa/admin-ui/actions/runs/17070310234/job/48397247596?pr=1529#step:18:552)

Nagranie.z.ekranu.2025-08-20.o.21.20.53.mov

… consistency across form types.

sonarqubecloud · 2025-08-21T09:28:44Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

albozek added the Ready for review label Apr 24, 2025

albozek requested review from GrabowskiM, tischsoic, dew326, vexleet, OstafinL, RopRaptor and Copilot April 24, 2025 14:55

github-actions bot assigned dew326, ciastektk, mikadamczyk and ViniTou Apr 24, 2025

Copilot AI reviewed Apr 24, 2025

View reviewed changes

src/bundle/Resources/public/js/scripts/admin.notifications.list.js Outdated Show resolved Hide resolved

albozek force-pushed the ibx_9060 branch from ebb4316 to 8f12575 Compare April 25, 2025 09:18

tbialcz force-pushed the ibx_9060 branch 2 times, most recently from 106b699 to 46edda7 Compare April 29, 2025 07:41

albozek force-pushed the ibx_9060 branch 2 times, most recently from 485f3de to d537c29 Compare April 29, 2025 12:58

RopRaptor approved these changes May 5, 2025

View reviewed changes

src/bundle/Resources/public/js/scripts/admin.notifications.list.js Outdated Show resolved Hide resolved

albozek force-pushed the ibx_9060 branch from f4bf717 to 30f2e6b Compare May 5, 2025 11:47

OstafinL requested changes May 6, 2025

View reviewed changes

albozek force-pushed the ibx_9060 branch from 30f2e6b to 0353234 Compare May 6, 2025 10:03

albozek requested a review from OstafinL May 7, 2025 08:48

tbialcz and others added 7 commits May 8, 2025 12:16

IBX-9060: Added renderAllNotificationsPageAction and markNotification…

b8137fe

…AsUnreadAction

IBX-9060: Moved pagination rendering to Twig template and simplified …

b510b9e

…controller logic

IBX-9060: Added delete action and delete multiple notifications

6ce7874

IBX-9060: notification views changes

c23d494

IBX-9060: Added search form and query support to notifications page

3dd59ad

IBX-9060: Fixed modal

2f7208c

IBX-9060: Fixed all list

b327aa2

Steveb-p reviewed Aug 8, 2025

View reviewed changes

IBX-9060: Refactored notification handling: removed Translator depend…

53f25a9

…ency, improved error handling, and updated forms and translations.

tbialcz requested a review from Steveb-p August 8, 2025 10:09

ViniTou reviewed Aug 8, 2025

View reviewed changes

src/bundle/Controller/NotificationController.php Outdated Show resolved Hide resolved

tbialcz added 3 commits August 11, 2025 15:04

IBX-9060: Updated ibexa/core dependency to stable version constraint

75fc7d3

Merge branch '4.6' into ibx_9060

cab454a

IBX-9060: Improved form validation and error handling in notification…

f28b2c7

… deletion flow.

konradoboza reviewed Aug 12, 2025

View reviewed changes

src/bundle/Controller/NotificationController.php Outdated Show resolved Hide resolved

tbialcz force-pushed the ibx_9060 branch from e796422 to 1741bf0 Compare August 12, 2025 07:37

tbialcz requested review from tbialcz and ViniTou August 12, 2025 07:39

IBX-9060: Simplified notification deletion flow.

5a39de6

tbialcz force-pushed the ibx_9060 branch from 1741bf0 to 5a39de6 Compare August 12, 2025 07:41

tbialcz added the Ready for QA label Aug 13, 2025

KamilSznajdrowicz requested changes Aug 14, 2025

View reviewed changes

tbialcz and others added 3 commits August 19, 2025 09:43

Merge branch '4.6' into ibx_9060

dcac591

# Conflicts: # phpstan-baseline.neon # src/lib/Form/Factory/FormFactory.php

After QA

9abc197

IBX-9060: Fixed FormFactory Types and improved type annotations.

83eafd2

tbialcz force-pushed the ibx_9060 branch from e97b632 to 83eafd2 Compare August 19, 2025 11:28

GrabowskiM requested changes Aug 19, 2025

View reviewed changes

Reload notificationList after closing modal

4d8ced0

albozek requested a review from GrabowskiM August 19, 2025 13:31

KamilSznajdrowicz requested changes Aug 20, 2025

View reviewed changes

tbialcz force-pushed the ibx_9060 branch from 32cb1f2 to 5b905b3 Compare August 21, 2025 06:57

IBX-9060: Updated FormFactory to improve naming strategies and ensure…

6f18aa8

… consistency across form types.

tbialcz force-pushed the ibx_9060 branch from 5b905b3 to 6f18aa8 Compare August 21, 2025 07:05

After QA pt2

a13f74e

albozek requested a review from KamilSznajdrowicz August 21, 2025 10:09

tischsoic approved these changes Aug 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

IBX-9060: Revamp notifications #1529

IBX-9060: Revamp notifications #1529

Uh oh!

albozek commented Apr 24, 2025 •

edited by tbialcz

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KamilSznajdrowicz left a comment •

edited

Loading

Uh oh!

Uh oh!

GrabowskiM Aug 19, 2025

Uh oh!

KamilSznajdrowicz left a comment •

edited

Loading

Uh oh!

sonarqubecloud bot commented Aug 21, 2025

Uh oh!

Uh oh!

IBX-9060: Revamp notifications #1529

Are you sure you want to change the base?

IBX-9060: Revamp notifications #1529

Uh oh!

Conversation

albozek commented Apr 24, 2025 • edited by tbialcz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs:

Description:

For QA:

Documentation:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KamilSznajdrowicz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GrabowskiM Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

KamilSznajdrowicz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 21, 2025

Quality Gate passed

Uh oh!

Uh oh!

albozek commented Apr 24, 2025 •

edited by tbialcz

Loading

KamilSznajdrowicz left a comment •

edited

Loading

KamilSznajdrowicz left a comment •

edited

Loading