IBX-10414: Drop save action from forms #1666
Conversation
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
barw4,
wiewiurdp,
konradoboza and
tbialcz
and removed request for
a team
ViniTou
force-pushed
the
ibx-10414-drop-save-action
branch
from
1904f81 to
a04dfc4
Compare
| @@ -256,14 +241,9 @@ | |||
| <target state="new">Name</target> | |||
| <note>key: role_update.name</note> | |||
| </trans-unit> | |||
| <trans-unit id="453d030fbc11c10c842807ff213039adfffbe051" resname="role_update.save"> | |||
| <trans-unit id="004e2e90e1b877d6a3c2def0a6f50ad62ef5f019" resname="role_update.save_and_close"> | |||
There was a problem hiding this comment.
The key here is "role_update.save_and_close", but the translation is "Save". Is it intended?
There was a problem hiding this comment.
Yes in all cases - the button changed label but the functionality did not change - I didnt want to mess up with someone translation as we could end with translated Save and close but what we want is just Save there.
src/bundle/Resources/translations/ibexa_content_forms_role.en.xliff
Outdated
Show resolved
Hide resolved
src/lib/Form/Type/ContentTypeGroup/ContentTypeGroupCreateType.php
Outdated
Show resolved
Hide resolved
| @@ -95,8 +72,7 @@ public function createStructure(array $options): ItemInterface | |||
| public static function getTranslationMessages(): array | |||
| { | |||
| return [ | |||
| (new Message(self::ITEM__SAVE, 'ibexa_menu'))->setDesc('Save'), | |||
| (new Message(self::ITEM__SAVE_AND_CLOSE, 'ibexa_menu'))->setDesc('Save and close'), | |||
| (new Message(self::ITEM__SAVE_AND_CLOSE, 'ibexa_menu'))->setDesc('Save'), | |||
There was a problem hiding this comment.
| (new Message(self::ITEM__SAVE_AND_CLOSE, 'ibexa_menu'))->setDesc('Save'), | |
| (new Message(self::ITEM__SAVE, 'ibexa_menu'))->setDesc('Save'), |
?
There was a problem hiding this comment.
Those are buttons IDs, that would change id associated with current behaviour, ergo could introuduce some sort of bc breaks.
| * @throws \InvalidArgumentException | ||
| * @throws ApiExceptions\BadStateException | ||
| * @throws \InvalidArgumentException | ||
| */ | ||
| public function createStructure(array $options): ItemInterface | ||
| { | ||
| $saveId = $options['save_id']; | ||
| $saveAncCloseId = $options['save_and_close_id']; | ||
| $saveAndCloseId = $options['save_and_close_id']; |
There was a problem hiding this comment.
Should it be save_and_close_id as the button is about creating?
There was a problem hiding this comment.
they are all named like this, for update as well, sometimes they are named save_and_edit, I really do not want to change all of them now. Even more that technicaly is BC break.
|
@mikadamczyk |
pawlakadrian
force-pushed
the
ibx-10414-drop-save-action
branch
from
84c281f to
498123d
Compare
|
Related PRs:
Description:
For QA:
List of affected create/update forms:
Documentation: