Added sorting options to ibexa:debug:config
#631
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
force-pushed
the
enh-ibexa-debug-config
branch
from
e562db5 to
ea930f3
Compare
adriendupuis
force-pushed
the
enh-ibexa-debug-config
branch
from
ea930f3 to
1aad6d2
Compare
|
adamwojs
reviewed
Aug 14, 2025
| @@ -95,6 +107,18 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $scope = $input->getOption('scope'); | |||
| $parameterData = $this->configResolver->getParameter($parameter, $namespace, $scope); | |||
|
|
|||
| if (null !== ($sort = $input->getOption('sort')) && is_array($parameterData) && is_array($parameterData[0]) && array_key_exists($sort, $parameterData[0]) && is_scalar($parameterData[0][$sort])) { | |||
There was a problem hiding this comment.
Can we somehow simplify this check ?
| @@ -95,6 +107,18 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $scope = $input->getOption('scope'); | |||
| $parameterData = $this->configResolver->getParameter($parameter, $namespace, $scope); | |||
|
|
|||
| if (null !== ($sort = $input->getOption('sort')) && is_array($parameterData) && is_array($parameterData[0]) && array_key_exists($sort, $parameterData[0]) && is_scalar($parameterData[0][$sort])) { | |||
| if ($input->getOption('reverse-sort')) { | |||
| usort($parameterData, static function ($a, $b) use ($sort) { | |||
There was a problem hiding this comment.
Suggested change
| usort($parameterData, static function ($a, $b) use ($sort) { | |
| usort($parameterData, static function ($a, $b): int use ($sort) { |
Could you also please specify types for $a and $b ?
| return $b[$sort] <=> $a[$sort]; | ||
| }); | ||
| } else { | ||
| usort($parameterData, static function ($a, $b) use ($sort) { |
There was a problem hiding this comment.
Suggested change
| usort($parameterData, static function ($a, $b) use ($sort) { | |
| usort($parameterData, static function ($a, $b): int use ($sort) { |
Could you also please specify types for $a and $b ?
adriendupuis
changed the title
ibexa:debug:config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sort parameter list when sortable, when it's an array of arrays by a scalar value's key.
For example, see
adminsiteaccess field templates by decreasing priority:php bin/console ibexa:debug:config field_templates --siteaccess admin --sort priority --reverse-sortFor QA:
Documentation: