IBX-10440: Changed base icon size #78
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates icon sizes in the matrix fieldtype templates by changing the CSS class from ibexa-icon--small to ibexa-icon--small-medium for better visual consistency.
- Changed icon size class from
--smallto--small-mediumacross matrix fieldtype templates - Updated both field type configuration and content edit form templates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| field_types.html.twig | Updated icon size classes for add column and remove column buttons |
| content_edit_form_fields.html.twig | Updated icon size classes for add/remove matrix entry buttons |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -37,7 +37,7 @@ | |||
| class="btn ibexa-btn ibexa-btn--secondary ibexa-btn--small ibexa-btn--add-matrix-entry" | |||
| {{ readonly ? 'disabled' }} | |||
| > | |||
| <svg class="ibexa-icon ibexa-icon--small ibexa-icon--edit"> | |||
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--edit"> | |||
There was a problem hiding this comment.
The CSS class ibexa-icon--edit appears to be incorrect for an add/create action. This should likely be ibexa-icon--create to match the icon being used (create from the use xlink:href).
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--edit"> | |
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--create"> |
Copilot uses AI. Check for mistakes.
| @@ -47,7 +47,7 @@ | |||
| class="btn ibexa-btn ibexa-btn--ghost ibexa-btn--small ibexa-btn--bulk-remove-matrix" | |||
| {{ readonly ? 'disabled' }} | |||
| > | |||
| <svg class="ibexa-icon ibexa-icon--small ibexa-icon--edit"> | |||
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--edit"> | |||
There was a problem hiding this comment.
The CSS class ibexa-icon--edit appears to be incorrect for a remove/delete action. This should likely be ibexa-icon--trash to match the icon being used (trash from the use xlink:href).
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--edit"> | |
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--trash"> |
Copilot uses AI. Check for mistakes.
| @@ -77,7 +77,7 @@ | |||
| class="btn ibexa-btn ibexa-btn--ghost ibexa-btn--no-text ibexa-btn--remove-matrix-entry" | |||
| {{ readonly ? 'disabled' }} | |||
| > | |||
| <svg class="ibexa-icon ibexa-icon--small ibexa-icon--edit"> | |||
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--edit"> | |||
There was a problem hiding this comment.
The CSS class ibexa-icon--edit appears to be incorrect for a remove/delete action. This should likely be ibexa-icon--trash to match the icon being used (trash from the use xlink:href).
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--edit"> | |
| <svg class="ibexa-icon ibexa-icon--small-medium ibexa-icon--trash"> |
Copilot uses AI. Check for mistakes.
Related PRs:
Description:
For QA:
Documentation: