Skip to content

Conversation

@j4real2208
Copy link
Contributor

Contributes to: mhub/qp-planning#9700

Signed-off-by: JOJO Johnson [email protected]

Copy link
Contributor

@ajborley ajborley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the updates

@Kartikey-Mishra1
Copy link

Kartikey-Mishra1 commented Jan 19, 2023

Sorry just wanted to confirm that you didn't make any changes in the package.json because in the package-lock.json I can see some changes in the package versions
image

@j4real2208
Copy link
Contributor Author

Sorry just wanted to confirm that you didn't make any changes in the package.json because in the package-lock.json I can see some changes in the package versions image

Yes @Kartikey-Mishra1 There were changes made to the dependencies. But it was achieved through npm audit fix. But I will look into it again and confirm the changes made .

@Kartikey-Mishra1
Copy link

Kartikey-Mishra1 commented Jan 19, 2023

Sure 👍, can you also push your package.json as well then if it contains any changes

Contributes to: mhub/qp-planning#9700

Signed-off-by: JOJO Johnson <[email protected]>
@neeraj-laad
Copy link
Contributor

replaced by #364

@neeraj-laad neeraj-laad closed this Nov 7, 2024
trevor-dolby-at-ibm-com added a commit to trevor-dolby-at-ibm-com/kafka-java-vertx-starter that referenced this pull request Nov 10, 2024
trevor-dolby-at-ibm-com added a commit to trevor-dolby-at-ibm-com/kafka-java-vertx-starter that referenced this pull request Nov 10, 2024
* Try with PR only

* Try node 16

* node 20 with corrected PR

* feat: fix workflow

Signed-off-by: Your Name [email protected]

* feat: update to node.js 20

Signed-off-by: Trevor Dolby <[email protected]>

* feat: update dependencies starter app (ibm-messaging#348)

---------

Signed-off-by: Trevor Dolby <[email protected]>
neeraj-laad pushed a commit that referenced this pull request Nov 15, 2024
* Update Java prereqs

Signed-off-by: Trevor Dolby <[email protected]>

* Update Java prereqs

Signed-off-by: Trevor Dolby <[email protected]>

* Enable workflow dispatch

* Try node 20

* Try manual test

* feat: fix commit lint nodejs issue (#2)

* Try with PR only

* Try node 16

* node 20 with corrected PR

* feat: fix workflow

Signed-off-by: Your Name [email protected]

* feat: update to node.js 20

Signed-off-by: Trevor Dolby <[email protected]>

* feat: update dependencies starter app (#348)

---------

Signed-off-by: Trevor Dolby <[email protected]>

* feat: fix commit lint text issue (#2)

---------

Signed-off-by: Trevor Dolby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants