Conversation
Member
|
I don't think there's a need to cache the context menu; can you just return a new one from GetContextMenu()? That makes the code simpler (and more concentrated in one location). |
Member
|
Sorry, but storing a context menu per tree node is not an option. Tree nodes are supposed to be light-weight (there can be many thousands of them in memory!), they shouldn't reference any WPF objects. |
This reverts commit b2c532b.
…tMenu field member.
pgourlain
pushed a commit
to pgourlain/ILSpy
that referenced
this pull request
Apr 15, 2014
siegfriedpammer
pushed a commit
that referenced
this pull request
Dec 21, 2018
Update UniversalAssemblyResolver to include missing .NET 3 support
siegfriedpammer
pushed a commit
that referenced
this pull request
Aug 8, 2020
Discussion about the translations
riQQ
pushed a commit
to riQQ/ILSpy
that referenced
this pull request
Mar 23, 2021
Fixed decompiler exception which is thrown in case there are referenc…
siegfriedpammer
added a commit
that referenced
this pull request
Aug 20, 2024
WPF Refactoring #1: Add abstraction layer for MEF
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to make sure that you agree with this.