ADTs #141
Open
ADTs #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, $o instanceof Option::Some is just treated as $o instanceof
('Option::Some'), which has some obvious limitations. It cannot support
static, which is only really useful for traits. More significantly, it also
cannot support $o instanceof Option::None, because we don't generate classes for
singleton cases.
iluuu1994
force-pushed
the
master
branch
12 times, most recently
from
ec2ad32 to
ee19427
Compare
iluuu1994
force-pushed
the
master
branch
6 times, most recently
from
ac43dcd to
1922f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADTs