Skip to content

Conversation

@ahnv
Copy link
Member

@ahnv ahnv commented Nov 21, 2025

This pull request updates the ImageKit Editor to version 1.2.0 and introduces several UI improvements to the editor's header and wrapper components. The main focus is on enhancing the appearance and consistency of the header buttons and layout, as well as ensuring the correct z-index stacking for the editor wrapper.

Version Updates:

  • Upgraded @imagekit/editor dependency and package version from 1.1.0 to 1.2.0 in both examples/react-example/package.json and packages/imagekit-editor/package.json. [1] [2]

UI Improvements in Header:

  • Standardized header button styles by setting height="full", borderRadius="0", and px="8" for export and close buttons, and updated the export menu button to use MenuButton as={Button} for consistency. [1] [2]
  • Adjusted header layout by adding paddingRight="0", removing gap="4", and adding mr="4" to the icon for improved spacing and alignment.

Editor Wrapper Styling:

  • Changed the zIndex of the editor wrapper from "modal" to a fixed value of 2100 to ensure proper stacking over other elements.

@ahnv ahnv requested a review from Copilot November 21, 2025 05:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the ImageKit Editor to version 1.2.0 and implements UI improvements focused on standardizing header button styling and improving layout consistency. The changes ensure uniform button appearance across the header and adjust z-index stacking for proper layering.

Key changes:

  • Version bump from 1.1.0 to 1.2.0 for the ImageKit Editor package
  • Standardized header button styling with consistent height, border radius, and padding
  • Refined header layout spacing by removing gaps and adjusting padding
  • Updated editor wrapper z-index from theme token to fixed numeric value

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/imagekit-editor/package.json Updates package version to 1.2.0
packages/imagekit-editor-dev/src/components/header/index.tsx Standardizes button styling and refines header layout spacing
packages/imagekit-editor-dev/src/components/editor/wrapper.tsx Changes z-index from theme token to fixed value for consistent stacking
examples/react-example/package.json Updates ImageKit Editor dependency to version 1.2.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<Box
position="fixed"
zIndex="modal"
zIndex="2100"
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a magic number (2100) for z-index instead of a named constant or theme token reduces maintainability. Consider defining this value as a constant (e.g., EDITOR_WRAPPER_Z_INDEX = 2100) or documenting why this specific value is necessary, especially since it replaces a semantic theme token 'modal'.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants