Skip to content

ci: use awalsh128/cache-apt-pkgs-action@latest to cache apt install #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

kkysen
Copy link
Contributor

@kkysen kkysen commented Jul 14, 2025

We already use this GitHub Action on other projects like IA2 and rav1d.

Base automatically changed from kkysen/ci-python-uv to master July 14, 2025 15:46
@kkysen
Copy link
Contributor Author

kkysen commented Jul 14, 2025

@thedataking, can you allow awalsh128/cache-apt-pkgs-action to use, since we already use it in IA2 and rav1d? Also, if you're already doing that, can you also allow dtolnay/rust-toolchain? It's used by most rust-lang/ repos.

@kkysen kkysen force-pushed the kkysen/ci-cache-apt-install branch from 5fa8111 to 35f6f08 Compare July 15, 2025 03:59
@thedataking
Copy link
Contributor

I've whitelisted awalsh128/cache-apt-pkgs-action.

Why do you need dtolnay/rust-toolchain? I'd like to understand the need before we polish our CI actions further.

(we have Swatinem/rust-cache@v2 enabled in case that's relevant.)

Copy link
Contributor Author

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need dtolnay/rust-toolchain? I'd like to understand the need before we polish our CI actions further.

(we have Swatinem/rust-cache@v2 enabled in case that's relevant.)

We actually don't. rust-cache covers it, I just had to reverse the order of the steps. So we should be all good now. Thanks!

We already use this GitHub Action on other projects like IA2 and rav1d.
@kkysen kkysen force-pushed the kkysen/ci-cache-apt-install branch from 35f6f08 to 12188cb Compare July 25, 2025 06:57
Copy link
Contributor Author

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've whitelisted awalsh128/cache-apt-pkgs-action.

Still seems to be blocked 😞 https://github.com/immunant/c2rust/actions/runs/16515868669. Not sure why. Is there something I need to update? I just rebased.

@thedataking
Copy link
Contributor

Still seems to be blocked 😞

I think I forgot to press save. My bad, very sorry 😞

@kkysen kkysen closed this Jul 25, 2025
@kkysen kkysen reopened this Jul 25, 2025
@kkysen
Copy link
Contributor Author

kkysen commented Jul 25, 2025

I think I forgot to press save. My bad, very sorry 😞

😆 https://github.com/immunant/c2rust/actions/runs/16516133789 I tried closing and reopening the PR, but it/s still denying it.

@kkysen kkysen closed this Jul 25, 2025
@kkysen kkysen reopened this Jul 25, 2025
@kkysen kkysen closed this Jul 25, 2025
@kkysen kkysen reopened this Jul 25, 2025
@kkysen kkysen merged commit 6b4eb85 into master Jul 25, 2025
16 checks passed
@kkysen kkysen deleted the kkysen/ci-cache-apt-install branch July 25, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants