Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This nix devshell was a bit jank. I cleaned it up, and also added a nix derivation.
This is fine because the version in nixpkgs is the same version that was being fetched via git anyways.
This provides things that c2rust needs in its environment to run, such as setting up PATH and other things.
This is basically the same as before. It is hooked up to the flake too.
This allows to check that it builds when updating and other things.
This is very useful, because it allows for people to directly import c2rust as an overlay into their NixOS config, home-manager config, or devshells.
I am unsure what sort of scope the project would like for Nix integration. This is basically the minimum of being able to build it on Nix easily. There are other things that could be done:
There is a TODO for a test failures:
c2rust/c2rust-analyze/tests/analyze.rs
Line 47 in 2120093
And various filecheck failures. It also looks like there is some sort of race happening on stderr output?
filecheck.log