Skip to content

test_translator: remove #![feature(nll)], stabilized in 1.63 #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

kkysen
Copy link
Contributor

@kkysen kkysen commented Jul 18, 2025

Our old pinned nightly is 1.65, so this was already stabilized even back then.

Our old pinned nightly is 1.65, so this was already stabilized even back then.
@kkysen kkysen requested a review from fw-immunant July 18, 2025 20:47
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is fine, but as an aside I'd like to understand better what the source of truth for compatibility of our generated code is. Do you happen to know offhand? I can't find anything about this in our docs.

@fw-immunant
Copy link
Contributor

Is this the toolchain we expect transpiled code to compile against?

[toolchain]
channel = "nightly-2022-08-08"
components = ["rustfmt"]

Copy link
Contributor Author

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the toolchain we expect transpiled code to compile against?

[toolchain]
channel = "nightly-2022-08-08"
components = ["rustfmt"]

Yes, everything is pinned to this nightly and is detected whenever we run cargo/rustc.

@kkysen
Copy link
Contributor Author

kkysen commented Jul 23, 2025

The exception is when we publish, as that's broken on the old nightly. I use stable to publish.

@kkysen kkysen merged commit be24dbd into master Jul 23, 2025
5 checks passed
@kkysen kkysen deleted the kkysen/remove-stabilized-feature-nll branch July 23, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants