transpile: revert __builtin_ia32_pause/__builtin_arm_yield to emit _mm_pause and __yield instead of cross-platform spin_loop
#1292
+90
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
changed the base branch from
kkysen/ci-arm64-macos
to
kkysen/arch-specific-snapshots
kkysen
force-pushed
the
kkysen/revert-spin_loop
branch
from
b990568 to
84affd0
Compare
`__yield` is the more direct, unstable equivalent of `__builtin_arm_yield`. Fixes 1st half of <#1263 (comment)>.
`_mm_pause` is the more direct, unstable equivalent of `__builtin_ia2_pause`. Fixes 2nd half of <#1263 (comment)>.
kkysen
force-pushed
the
kkysen/revert-spin_loop
branch
from
84affd0 to
cd6c23b
Compare
thedataking
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
LGTM.
The import_simd_function can also cause stdstimd to be used. Would it make sense to open an issue capturing the TODOs you noted for deprecation and reference that issue in both locations where stdsimd might be pulled in? E.g.
// TODO(#123): In Rust 1.88 (probably earlier), `#![feature(stdsimd)]` has been removed
You can easily test if it was pulled in 1.88 or 1.87 using compiler-explorer if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1263 (comment).
This switches back to emitting the more direct but unstable translations of
_mm_pauseand__yield.