Re-enable --reorganize-definitions flag

[fw-immunant]

It's currently a no-op. We'll also want to make it run by default, which is where it seems more likely we'll run into CI/release trouble due to our complex rustc version requirements.

[ahomescu]

I had completely forgotten we had this, it probably would have fixed the issue from the libxml2 demo.

[fw-immunant]

Fixed a couple issues where the tests were overly brittle; now in cargo test only tests/simd.x86_64 seems to fail; many errors around not-found types, such as:

error[E0412]: cannot find type `__m128` in this scope

[fw-immunant]

The problem seems to be that imports of needed types for SIMD get placed into submodules and then these types are not in scope for their later usage:

#include <immintrin.h>

void simd_fn_codegen(__m128i i)
{
    i = _mm_aesdeclast_si128(i, i);
}

transpiles with --reorganize-definitions to:

#![allow(
    dead_code,
    non_camel_case_types,
    non_snake_case,
    non_upper_case_globals,
    unused_assignments,
    unused_mut
)]
#![register_tool(c2rust)]
#![feature(register_tool, stdsimd)]
#[c2rust::header_src = "/usr/lib/clang/21/include/mmintrin.h:1"]
pub mod mmintrin_h {
    #[cfg(target_arch = "x86")]
    pub use ::core::arch::x86::__m128i;
    #[cfg(target_arch = "x86_64")]
    pub use ::core::arch::x86_64::__m128i;
}
#[c2rust::header_src = "/usr/lib/clang/21/include/__wmmintrin_aes.h:1"]
pub mod __wmmintrin_aes_h {
    #[cfg(target_arch = "x86")]
    pub use ::core::arch::x86::_mm_aesdeclast_si128;
    #[cfg(target_arch = "x86_64")]
    pub use ::core::arch::x86_64::_mm_aesdeclast_si128;
}
#[cfg(target_arch = "x86")]
pub use ::core::arch::x86::_mm_setzero_si128;
#[cfg(target_arch = "x86_64")]
pub use ::core::arch::x86_64::_mm_setzero_si128;
#[no_mangle]
#[c2rust::src_loc = "3:1"]
pub unsafe extern "C" fn rust_simd_fn_codegen(mut i: __m128i) {
    i = _mm_aesdeclast_si128(i, i);
}

[fw-immunant]

Ah, there's another problem here: if -e/--emit-build-files is not passed (e.g. as when invoked from test_translator.py), the transpiler skips invoking the refactorer entirely, but does still change its output to include mods for headers and the various c2rust::src_loc/c2rust::header_src attributes. In this case the output does not compile at all, so even passing -e just results in the transpiler balking with:

warning: Reorganizing definitions failed: Crate does not compile.

So it seems we need to fix this in the transpiler, not the refactorer, and may also need to alter how the transpiler is invoked by test_translator.py if we want those tests to actually benefit from the refactorer.

[fw-immunant]

The next set of errors in CI are the testsuite failing due to __sigset_t and C2RustUnnamed types not being imported for some reason.

[fw-immunant]

Now I'm seeing c2rust-refactor: error while loading shared libraries: librustc_driver-14a53782e7072fd8.so: cannot open shared object file: No such file or directory. Presumably a library path issue of some kind.

[kkysen]

Split into and superseded by #1451 and #1452.