refactor: avoid reordering attributes when restoring them #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I added a test but I'm not sure that these c2rust-refactor tests are actually run in CI. It seems like we're not running |
ahomescu
requested changes
Oct 28, 2025
kkysen
reviewed
Oct 28, 2025
Contributor
There was a problem hiding this comment.
Can this just be written as a Rust #[test] instead? cargo test is run in CI.
Contributor
There was a problem hiding this comment.
test_rust_refactor.py is pretty small (unlike test_translator.py), and it makes a lot of things more seamless to keep it all in cargo test.
Contributor
Author
There was a problem hiding this comment.
We do want to test end-to-end refactorer behavior here if possible, so if you have a suggestion on how to express that as a #[test] (e.g. setting up integrated snapshot testing for the refactorer), I'm all ears.
fw-immunant
force-pushed
the
fw/refactor-derives
branch
from
9a2ef27 to
1251c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426, including in the presence of multiple
#[derive(...)]attributes interleaved with other attributes. No test at present; I'll look into adding one.