Keep order of typoscript keys #662
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys in a typoscript configuration are considered to express the priority of the values.
Like in view.templateRootPaths the highest value should be used. This is not the case with the current implementation.
This might be caused by a core issue, since
->getConfiguration(ConfigurationManagerInterface::CONFIGURATION_TYPE_FRAMEWORK, 'femanager'); should return the arrays in correct order. But it doesn't, the key depend on the order of imports of typoscript.
The Typoscript Module takes that in consideration and shows the correct order:
The configuration received in
femanager/Classes/Utility/TemplateUtility.php
Line 48 in 74e3661
Since finally only the last entry is returned in
femanager/Classes/Utility/TemplateUtility.php
Line 85 in 74e3661
This PR restores the order by sorting the keys and returning an array of sorted entries according to the key order.