Skip to content

Conversation

josefglatz
Copy link

No description provided.

@josefglatz josefglatz changed the title PHP 8 and TYPO3 related updates PHP 8 and TYPO3 related updates #17 Oct 8, 2022
@einpraegsam
Copy link
Contributor

Thx for your work Josef, I just added some comments to the code itself when you have some time for me :)

@josefglatz
Copy link
Author

@einpraegsam Hey Alex, where can I find your comments?

* @return void
*/
public function showAction()
public function showAction(): ResponseInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Is this still ok for TYPO3 10? I'm asking because otherwise, we have to adjust the requirements.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's ok I would leave it as-is and therefore remove the support for TYPO3 10. Since the extension looks like it's feature complete and TYPO3 v12 is coming I would suggest to support only v11 – if OK for you Alex!

I will update therefore the proper constraints.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einpraegsam would love to hear from you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, dropping support for 10 is fine also for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants