[BUGFIX] Respect TCA rootLevel setting #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target pid is adjusted during imports, as the TCA rootLevel setting is not considered the pid is e.g. adjusted for sys_file_metadata, this will cause errors if not imported to root page (=0). By checking the TCA rootLevel setting of the imported tables and skipping the adjustment for all tables that can only exist in the root, this issue is fixed. Resolves: in2code-de#37
|
Thx for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target pid is adjusted during imports, as the TCA rootLevel setting is not considered the pid is e.g. adjusted for sys_file_metadata, this will cause errors if not imported to root page (=0).
By checking the TCA rootLevel setting of the imported tables and skipping the adjustment for all tables that can only exist in the root, this issue is fixed.
Resolves: #37