#4931 - Support for GraphDB knowledge bases - #4932
Merged
Merged
Conversation
reckart
force-pushed
the
feature/4931-Support-for-GraphDB-knowledge-bases
branch
from
July 6, 2024 20:09
eaec460 to
574a4db
Compare
- Tentative support - fails many tests
reckart
force-pushed
the
feature/4931-Support-for-GraphDB-knowledge-bases
branch
from
March 24, 2025 20:30
a26a723 to
0755e24
Compare
…ases * main: (537 commits) #5903 - Decompose assistant panel into multiple components No issue. Adjust egress whitelist #2389 - Prevent curation until ANNOTATION_FINISHED #2389 - Prevent curation until ANNOTATION_FINISHED #5793 - Upgrade dependencies #2389 - Prevent curation until ANNOTATION_FINISHED #4941 - Mapping OIDC groups to INCEpTION's internal roles #5716 - Multiple no-label suggestions if there are multiple recommenders for different features on one layer #5716 - Multiple no-label suggestions if there are multiple recommenders for different features on one layer #2389 - Prevent curation until ANNOTATION_FINISHED #5716 - Multiple no-label suggestions if there are multiple recommenders for different features on one layer #4941 - Mapping OIDC groups to INCEpTION's internal roles #5775 - Cleaning up #4941 - Mapping OIDC groups to INCEpTION's internal roles #4941 - Mapping OIDC groups to INCEpTION's internal roles #5793 - Upgrade dependencies #4941 - Mapping OIDC groups to INCEpTION's internal roles #4941 - Mapping OIDC groups to INCEpTION's internal roles #4941 - Mapping OIDC groups to INCEpTION's internal roles #4941 - Mapping OIDC groups to INCEpTION's internal roles ...
- Use bsaic GraphDB configuration without inference to fix most tests - Upload license into test container if license is available - otherwise skip tests - Pre-resolve label properties for more stable tests (and fixing some problems with "*" path resolution in GraphDB)
- Fix GraphDB FTS - Fix tests - Pin GraphDB version - Pin Keycloak version
There was a problem hiding this comment.
Pull request overview
This PR adds GraphDB as a supported remote knowledge base backend (including full-text search integration) and updates tests and documentation to accommodate the new backend and newer Keycloak behavior.
Changes:
- Add a GraphDB full-text-search adapter and supporting SPARQL query building utilities.
- Add/adjust tests to resolve effective label properties up-front and to validate GraphDB/Keycloak behavior.
- Update user documentation and supporting configuration (IRIs, gitignore, Maven deps).
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| inception/inception-ui-kb/src/main/resources/META-INF/asciidoc/user-guide/projects_knowledge-base.adoc | Documents GraphDB FTS configuration and inference disabling. |
| inception/inception-security/src/test/resources/keycloak/inception-security-test-realm.json | Adjusts Keycloak test realm to allow non-SSL HTTP access. |
| inception/inception-security/src/test/java/de/tudarmstadt/ukp/inception/security/oauth/OAuth2AdapterImplKeycloakTest.java | Updates Keycloak testcontainer image usage and replaces admin-client check with OIDC discovery validation. |
| inception/inception-security/pom.xml | Removes Keycloak admin client test dependencies no longer needed by tests. |
| inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilderRemoteServicesTest.java | Updates remote-service tests to pre-resolve preferred label properties. |
| inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilderLocalTestScenarios.java | Adds helper to resolve preferred label properties and updates scenarios accordingly. |
| inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilderGenericTest.java | Updates generic query-safety tests to pre-resolve preferred label properties. |
| inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/querybuilder/GraphDbRepositoryTest.java | Adds GraphDB docker-based integration test coverage. |
| inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/FullTextIndexUpgradeTest.java | Updates upgrade tests to pre-resolve preferred label properties before label matching. |
| inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/querybuilder/SPARQLQueryBuilder.java | Introduces GraphDB adapter selection and enforces pre-resolved preferred label properties for label-matching operations. |
| inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/querybuilder/GraphDbFtsQuery.java | Adds GraphDB-specific FTS query pattern builder. |
| inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/querybuilder/FtsAdapterGraphDb.java | Implements GraphDB FTS behavior (language-index unioning, wildcard/prefix handling). |
| inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/IriConstants.java | Adds GraphDB namespace + FTS IRI and exposes backend name. |
| inception/inception-kb/pom.xml | Adjusts Apache HttpComponents dependencies to support new GraphDB test code. |
| .gitignore | Ignores *.license files (e.g. GraphDB license). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ases#4931 - Support for GraphDB knowledge bases - Cleaning up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation