fix: treat numeric character reference CR as whitespace - #1832
Open
Steve0x2a wants to merge 1 commit into
Open
Conversation
isWhitespace omitted U+000D. Literal CRs are preprocessed to LF, but &inikulin#13; / 
 bypass the preprocessor and were emitted as CHARACTER tokens, inserting a stray CR text node before body. Credit @maximilliangrand for the report. Fixes inikulin#1828
Steve0x2a
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A leading
/
was emitted as a CHARACTER token becauseisWhitespace()did not include U+000D. Literal CRs are rewritten to LF by the preprocessor, so this only showed up for numeric character references.The before-html / before-head / in-head / after-head insertion modes then treated that token as “anything else” and inserted a stray CR text node in
<body>instead of ignoring it.This adds
CARRIAGE_RETURNtoisWhitespace. It does not rewrite NCR 0x0D to LF — the spec reports that ascontrolCharacterReferenceand keeps U+000D.Reported and diagnosed by @maximilliangrand.
Fixes #1828