-
Notifications
You must be signed in to change notification settings - Fork 291
Add support for Hyp3 INSAR_ISCE_MULTI_BURST format #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…for HDF-EOS5 metadata.
💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖 |
Reviewer's GuideThis pull request adds support for the Hyp3 File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KavyaKinjalk - I've reviewed your changes - here's some feedback:
- Using hardcoded indices for filename parsing reduces maintainability; consider alternatives like named constants or regular expressions.
- Consider refactoring the duplicated relative orbit calculation into a helper function.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Hi @KavyaKinjalk, The multi-burst InSAR HyP3 product is still very new and will likely have an update to its naming convention in the near future. I am using the following as a temporary workaround to rename the files so they can be loaded with
|
Hopefully they will just switch the name back to follow a similar convention because there really is no point in having a different name. Except for this part, everything else is still fully compatible. But both ways should work well. In my opinion, trying to find the file through the folder name sounds like a better idea than cutting the array off after 8. We will see what happens after they deprecate single burst.
Additionally, I would like to add that the current code should be fully backwards compatible with the original format for single bursts. If they were to change the naming structure to fix this issue, there will be nothing to worry about anyway. incorporating something similar to this would only help remove the current issues anyone would be facing with this format.
|
Hey @KavyaKinjalk just wanted to let you know that we're working on this at ASF and have started a GitHub issue to decide on a new name. |
Hey guys, sorry this has taken so long but we're finally getting around to updating the naming convention of these products to be compatible with MintPy without requiring changes. This documentation PR describes the format we're moving to. |
Description of proposed changes
adds compatibility for HyP3's INSAR_ISCE_MULTI_BURST job format.
Here as well, HyP3 generates a single interferogram from multiple reference and secondary bursts. To maintain compatibility with MintPy's data model, the first reference granule is selected to represent the acquisition metadata.
With this, MintPy can process HyP3 multi-burst ISCE2 products for time-series analysis and SBAS workflows.
Reminders