[MBL-19376][S] To-do - Sync widget content with in-app screen #3770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made TodoInteractor and TodoGroupViewModel public for widget access - Added alwaysExcludeCompleted parameter to TodoInteractor - Refactored TodoModel to work with grouped data instead of flat items - Updated TodoWidgetProvider to use TodoInteractor instead of manual filtering - Removed redundant flatten/regroup logic from widget 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Move alwaysExcludeCompleted to be the first parameter for better readability at call sites. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The widget now respects ExperimentalFeature.newStudentToDoScreen to match the main app's todo screen behavior. When disabled, restores the original calendar-based filtering to minimize regression risk. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ExperimentalFeature was using UserDefaults.standard which is not shared between the main app and widget extensions. This caused the widget to always use the old todo behavior regardless of the feature flag state. Now uses UserDefaults with app group suite name, matching SessionDefaults. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Make shortDayMonthFormatter respect the calendar's timezone so that dates are formatted consistently in tests and production. Extend unit tests with new functionality. refs: MBL-19376 builds: Student affects: Student release note: none test plan: - To-do widget should show the same items as the new calendar. - Turning off the dev feature flag should revert widget to its previous version
Claude Code ReviewUpdated: 2025-11-21 ✅ No critical issues found Summary:
|
Contributor
Affected Apps: StudentBuilds: Student
|
Contributor
BuildsCommit: Merge branch 'feature/MBL-19375-todo-filters' into feature/MBL-19376-Sync-todo-widget-content-with-todo-screen (14db4c5)
|
vargaat
changed the title
…Sync-todo-widget-content-with-todo-screen # Conflicts: # Core/Core/Features/Todos/Model/TodoInteractor.swift
Claude Code ReviewUpdated: 2025-11-24 Critical Issues Found
Observations
✅ Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
newStudentToDoScreenfeature flag and uses the new To-do data source if the flag is on.ExperimentalFeatureto use sharedUserDefaultsvia app group. This was needed for the widget to be able to read the flag states written by the app.refs: MBL-19376
builds: Student
affects: Student
release note: none
test plan:
Screenshots
Checklist