-
Notifications
You must be signed in to change notification settings - Fork 871
fix: allow missing types of rule bypasses #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Leave it to the API to determine if the values for actor_types are valid of not. These change over time and we would need to carry a list in code to verify this. Do not require an actor_id on rule bypasses. Things like DeployKey do not have an id. Signed-off-by: Johannes Wienke <[email protected]>
3e59908
to
08f50d6
Compare
Great work! I'd love it when we can finally add deploy keys too! |
closes #2748 |
Could we get this merged? Maybe @nickfloyd could help or knows someone who could? |
@nickfloyd any idea when we might see a release containing this fix? |
Loved to see it merged 🚀 when can I use it with a new release? 😄 |
Hey @dsdeboer I am looking to cut a release this week. I'm intentionally batching things up here because the next release will most likely have breaking changes - so I want as much functionality and fixes in this release for our community here that will release in a non-disruptive way. ❤️ |
This PR attempts to resolve an issue where the provider is not able to create bypass rules that don't use the explicit values set in this provider. The provider itself is out of date. There is no need for the provider to do the check as the API and helps will do the checks for us.
I've taken the liberty to update #2588 with the pending suggestions.
Resolves #2254
Resolves #2588
Before the change?
Users would not be able to make a bypass rule that uses something like a DeployKey
After the change?
Users can make any bypass rule that is accepted by the API
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!