-
Notifications
You must be signed in to change notification settings - Fork 563
feat: No Scan SOC for language parsers #5143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
=================================== FAILURES ===================================
_____________________ TestSourceOSV.test_update_ecosystems _____________________
self = <test.test_source_osv.TestSourceOSV object at 0x7fc350c791d0>
@pytest.mark.asyncio
@pytest.mark.skipif(not EXTERNAL_SYSTEM(), reason="Needs network connection.")
async def test_update_ecosystems(self):
await self.osv.update_ecosystems()
ecosystems_txt = make_http_requests(
"text", url=self.ecosystems_url, timeout=300
).strip("\n")
expected_ecosystems = set(ecosystems_txt.split("\n"))
# Because ecosystems.txt does not contain the complete list, this must be
# manually fixed up.
expected_ecosystems.add("DWF")
expected_ecosystems.add("JavaScript")
# Assert that there are no missing ecosystems
> assert all(x in self.osv.ecosystems for x in expected_ecosystems)
E assert False
E + where False = all(<generator object TestSourceOSV.test_update_ecosystems.<locals>.<genexpr> at 0x7fc34fe01b10>)
test/test_source_osv.py:1[84](https://github.com/intel/cve-bin-tool/actions/runs/15675174394/job/44153701064?pr=5143#step:15:85): AssertionError Might this error be due to the problems we are having with the OSV data source? |
I've merged #4929 which should solve the OSV problem so I'm going to try updating this branch |
Signed-off-by: joydeep049 <[email protected]>
I think this can be merged now After this is merged we have a full no-scan mode with proper outputs. Request anyone who has time to test it. |
Signed-off-by: joydeep049 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github diff + the black changes made this a pain to read, but I think we're good to go.
I see that the language parsers are mostly checking to see if cvedb exists and acting accordingly, which is great for cases where it didn't download for other reasons. I do wonder if the combo of "user specified no-scan but cvedb exists on disk" is going to be surprising to people, but.. maybe not? Probably better to just get this out in teh next pre-release and see.
Separation of Concerns for the language parser pipeline for the No-Scan Work.
cc @terriko @anthonyharrison @mastersans