[NFI]: XPUBackend refactoring to facilitate arch-specific implementations #5329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiotto
changed the title
etiotto
reviewed
Oct 16, 2025
XPUBackend is the base class. Arch-specific implementations derive from it and override the required methods. For example, they could override
It could be done, by defining a metaclass, but the inheritance should be used in most use-cases. |
- Allow metaclasses injection: use XPUBackendMeta from the .meta submodule as the metaclass, if it exists. - Try to find an arch-specific implementation in the .arch.<name> submodule. - Create the list of passes in separate methods to allow subclasses to modify it.
AndreyPavlenko
force-pushed
the
AndreyPavlenko/backend-refactor
branch
from
2c0c89d to
055acd2
Compare
| return pm | ||
|
|
||
| @classmethod | ||
| def get_ttir_passes(cls, opt): |
There was a problem hiding this comment.
How about we separate the changes about get_*ir_passes in another PR? I am not sure I like it, but the other changes don't need to be blocked by it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this refactoring is to simplify development for new architectures by subclassing the base class instead of adding conditional code blocks.
The main changes:
.arch.<name>submodule.