[Helion]: Remove boundaryChecks on load operation using a block ptr/te…

[etiotto]

We have implemented feature #5272 to collapse 3-dim loads on block ptrs into 2-dim loads when the tensor loaded has outermost dimension equal to 1. This feature compliments feature #5272. The goal here is to remove unnecessary boundaryCheck indexes on load operations if they are not necessary.

[whitneywhtsang]

please add a lit test

[chengjunlu]

Why we want to remove the boundary check while the hardware support the boundary check natively?
To remove the boundary check. We'd generate some different block IO than natural to override the boundary check in HW.

[whitneywhtsang]

Why we want to remove the boundary check while the hardware support the boundary check natively? To remove the boundary check. We'd generate some different block IO than natural to override the boundary check in HW.

It is to compliments feature #5272, it is not always safe to collapse dimensions when there is boundary check.

[etiotto]

please add a lit test

Added

[etiotto]

Why we want to remove the boundary check while the hardware support the boundary check natively? To remove the boundary check. We'd generate some different block IO than natural to override the boundary check in HW.

It is to compliments feature #5272, it is not always safe to collapse dimensions when there is boundary check.

Correct. The idea of this pass is to remove boundary checks that are provably not needed (the load is always inbound in the associated boundaryCheck dimension). The transformation in #5272 (which runs later in the pass pipeline) will then be able to collapse the outermost dimension of the block ptr is the boundary check is not present.

[etiotto]

@whitneywhtsang I have addressed review comments. How does it look now?