Skip to content

[PROTON][XPU] Fix utility function: enumDeviceUUIDs #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+8 −7
Merged

[PROTON][XPU] Fix utility function: enumDeviceUUIDs #5387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions third_party/intel/backend/proton_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ extern "C" void waitOnSyclQueue(void *syclQueue) {

// FIXME: Should it be in DeviceInfo class?
// Inspired by Kineto: `XpuptiActivityProfiler.cpp`
extern "C" void
enumDeviceUUIDs(std::vector<std::array<uint8_t, 16>> deviceUUIDs_) {
if (!deviceUUIDs_.empty()) {
extern "C" void enumDeviceUUIDs(void *deviceUUIDsPtr) {
auto *deviceUUIDs_ =
reinterpret_cast<std::vector<std::array<uint8_t, 16>> *>(deviceUUIDsPtr);
if (!deviceUUIDs_->empty()) {
return;
}
auto platform_list = sycl::platform::get_platforms();
Expand All @@ -24,13 +25,13 @@ enumDeviceUUIDs(std::vector<std::array<uint8_t, 16>> deviceUUIDs_) {
for (const auto &device : device_list) {
if (device.is_gpu()) {
if (device.has(sycl::aspect::ext_intel_device_info_uuid)) {
deviceUUIDs_.push_back(
deviceUUIDs_->push_back(
device.get_info<sycl::ext::intel::info::device::uuid>());
} else {
std::cerr << "Warnings: UUID is not supported for this XPU device. "
"The device index of records will be 0."
<< std::endl;
deviceUUIDs_.push_back(std::array<uint8_t, 16>{});
deviceUUIDs_->push_back(std::array<uint8_t, 16>{});
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions third_party/proton/csrc/lib/Profiler/Xpupti/XpuptiProfiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ void CallbackCommon(pti_callback_domain domain,
std::cout << std::endl;
}

typedef void (*EnumDeviceUUIDsFunc)(std::vector<std::array<uint8_t, 16>>);
typedef void (*EnumDeviceUUIDsFunc)(void *);

int callEnumDeviceUUIDs(const std::string &utils_cache_path) {
void *handle = dlopen(xpu::PROTON_UTILS.data(), RTLD_LAZY);
Expand All @@ -294,7 +294,7 @@ int callEnumDeviceUUIDs(const std::string &utils_cache_path) {
return 1;
}

enumDeviceUUIDs(deviceUUIDs_);
enumDeviceUUIDs(&deviceUUIDs_);

dlclose(handle);
return 0;
Expand Down