aarch64: use adrp + add instead of adr to avoid link time error: relo… #159
+86
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chenxuqiang @pablodelara please take a look |
…cation overflow in R_AARCH64_ADR_PREL_LO21, see intel#152 for more detail Signed-off-by: waldoweng <[email protected]>
Contributor
|
@chenxuqiang can you review this? Thanks! |
Contributor
|
Looks like @chenxuqiang is not available or hasn't seen this. @liuqinfei, could you take a look? |
mpiszczek
reviewed
Nov 7, 2025
mpiszczek
left a comment
mpiszczek
left a comment
There was a problem hiding this comment.
I have tested this patch and it solves the issue.
|
LGTM |
Contributor
|
@waldoweng For the sign-off line, we should use a full name. Can I use "Zhao Weng" as your full name? |
Contributor
Author
yes, please |
Contributor
|
This is now merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cation overflow in R_AARCH64_ADR_PREL_LO21, see #152 for more detail