Test new offload model #15121
Closed
Test new offload model #15121
+44
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudarsanam, Arvind <[email protected]>
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Sudarsanam, Arvind <[email protected]>
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Opened new PR with HIP testing |
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| /// Utility function to parse all devices passed via -fsycl-targets. | ||
| /// Return 'true' for JIT, AOT Intel CPU/GPUs and NVidia/AMD targets. | ||
| /// Otherwise return 'false'. | ||
| bool Driver::GetUseNewOffloadDriverForSYCLOffload(Compilation &C, |
There was a problem hiding this comment.
Here is a comment from Marcos "I think the name doesn't describe very well what the function is doing, or at least doesn't align very well with the description in the comment above. I would expect something including the words Get and Devices at least." More details can be found at #20470.
| options::OPT_offload_new_driver, false)) | ||
| return false; | ||
|
|
||
| if (Args.hasArg(options::OPT_fintelfpga)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for testing the new offload model for SYCL offloading. Please do not review.
Thanks