[UR][CUDA][Coverity] Don't check nvmlShutdown return in destructor #19512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UR_CHECK_ERROR` throws an exception so we can't use it from a destructor. Since devices only get released at application shutdown, there's not much we can do if `nvmlShutdown` reports an error, and the OS will promptly cleanup anything left as it tears down the process anyway. So just skip checking the error code from `nvmlShutdown`, this is already what we do for other cleanup/shutdown in this destructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_CHECK_ERRORthrows an exception so we can't use it from a destructor.Since devices only get released at application shutdown, there's not much we can do if
nvmlShutdownreports an error, and the OS will promptly cleanup anything left as it tears down the process anyway.So just skip checking the error code from
nvmlShutdown, this is already what we do for other cleanup/shutdown in this destructor.Fixes: #19500