[MSan] Use vector.reduce.or for >64-bit vector shadows on SPIR/SPIR-V targets#21757
Open
zhaomaosu wants to merge 1 commit intointel:syclfrom
Open
[MSan] Use vector.reduce.or for >64-bit vector shadows on SPIR/SPIR-V targets#21757zhaomaosu wants to merge 1 commit intointel:syclfrom
zhaomaosu wants to merge 1 commit intointel:syclfrom
Conversation
… targets When MSan instruments a load of a vector type whose total bit-width exceeds 64 (e.g. <3 x i32> = 96 bits, <4 x i32> = 128 bits), the existing shadow scalar conversion path will emit an instruction like `bitcast <3 x i32> %shadow to i96` (or wider). And i96 is only experimentally supported by GPU device. Fix: detect the SPIR/SPIR-V target and BitWidth > 64 case early emits a legal `llvm.vector.reduce.or` intrinsic that reduces to i32/i64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MSan instruments a load of a vector type whose total bit-width exceeds 64 (e.g. <3 x i32> = 96 bits, <4 x i32> = 128 bits), the existing shadow scalar conversion path will emit an instruction like
bitcast <3 x i32> %shadow to i96(or wider). And i96 is only experimentally supported by GPU device.Fix: detect the SPIR/SPIR-V target and BitWidth > 64 case early emits a legal
llvm.vector.reduce.orintrinsic that reduces to i32/i64.